Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization code #13999

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Optimization code #13999

wants to merge 2 commits into from

Conversation

FjPlays
Copy link

@FjPlays FjPlays commented Nov 12, 2024

added comment for clear details of the function

tobiasKaminsky and others added 2 commits November 12, 2024 16:03
…e-download-worker-for-two-way-sync

BugFix - Don't Use File Download Worker for Two Way Sync
@tobiasKaminsky
Copy link
Member

Thank you very much for your contribution.
We usually try to have no in-line documentation, as we want to have the code self explaining.
If we chose to write it, then it must be a tricky code, or a hard to understand reason.

In your added documentation I do not see a real win, as the code itself explains what it wants to do.
Except of L357 and L359.

Can you change it, so that only those two lines remain?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants