Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-3.30] TextWebView: allow to upload multiple attachements #13682

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Oct 2, 2024

Backport of PR #13546

Copy link

github-actions bot commented Oct 2, 2024

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13682.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Copy link

github-actions bot commented Oct 2, 2024

Lint

Typestable-3.30PR
Warnings6060
Errors33

SpotBugs

CategoryBaseNew
Bad practice6363
Correctness6464
Dodgy code300300
Experimental11
Internationalization77
Multithreaded correctness66
Performance5353
Security1818
Total512512

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 26.49%. Comparing base (ea19c02) to head (daffe17).
Report is 2 commits behind head on stable-3.30.

Files with missing lines Patch % Lines
...om/owncloud/android/ui/activity/EditorWebView.java 0.00% 7 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             stable-3.30   #13682      +/-   ##
=================================================
+ Coverage          26.30%   26.49%   +0.18%     
- Complexity          3385     3398      +13     
=================================================
  Files                658      658              
  Lines              48207    48213       +6     
  Branches            6461     6463       +2     
=================================================
+ Hits               12681    12773      +92     
+ Misses             33591    33485     -106     
- Partials            1935     1955      +20     
Files with missing lines Coverage Δ
...om/owncloud/android/ui/activity/EditorWebView.java 0.00% <0.00%> (ø)

... and 9 files with indirect coverage changes

@alperozturk96 alperozturk96 merged commit 7005ee0 into stable-3.30 Oct 2, 2024
20 of 21 checks passed
@alperozturk96 alperozturk96 deleted the backport/13546/stable-3.30 branch October 2, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants