Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check and show notification bell #13610

Merged
merged 11 commits into from
Oct 1, 2024
Merged

check and show notification bell #13610

merged 11 commits into from
Oct 1, 2024

Conversation

tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Sep 24, 2024

For #13051

  • Tests written, or not not needed

@tobiasKaminsky
Copy link
Member Author

image

Click on it leads to known notification view.

@tobiasKaminsky
Copy link
Member Author

I think with this approach we can remove the entry from drawer.

@tobiasKaminsky
Copy link
Member Author

@alperozturk96 can you help me and try to change the hamburger icon to "back <-" icon?
I tried to use similar approach like SettingsActivity.

@alperozturk96
Copy link
Collaborator

@tobiasKaminsky After this changes we don't need inheritance of DrawerActivity. Back button added and code is decoupled. df9bdac

Demo

fixed.mp4

@tobiasKaminsky
Copy link
Member Author

2024-09-26-093212

@alperozturk96 can you test it with a notification? 😨

@alperozturk96 alperozturk96 marked this pull request as draft September 26, 2024 07:49
@alperozturk96
Copy link
Collaborator

2024-09-26-093212

@alperozturk96 can you test it with a notification? 😨

Seems like after shifting top layout, it's not looking good. I will check it today.

tobiasKaminsky and others added 8 commits September 26, 2024 10:14
Signed-off-by: tobiasKaminsky <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Copy link
Collaborator

@tobiasKaminsky Now, it should look good for both low-resolution and high-resolution devices, whether there is a notification present or not.

1.mp4
2.mp4

@alperozturk96 alperozturk96 marked this pull request as ready for review September 26, 2024 08:16
alperozturk96 and others added 3 commits September 26, 2024 10:22
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: tobiasKaminsky <[email protected]>
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13610.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Copy link

Codacy

Lint

TypemasterPR
Warnings5959
Errors33

SpotBugs

CategoryBaseNew
Bad practice6464
Correctness6363
Dodgy code297297
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness66
Performance5353
Security1818
Total510510

@tobiasKaminsky tobiasKaminsky linked an issue Oct 1, 2024 that may be closed by this pull request
@tobiasKaminsky tobiasKaminsky merged commit d80612b into master Oct 1, 2024
21 checks passed
@tobiasKaminsky tobiasKaminsky deleted the notification branch October 1, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-order and group drawer items?
2 participants