-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check and show notification bell #13610
Conversation
I think with this approach we can remove the entry from drawer. |
@alperozturk96 can you help me and try to change the hamburger icon to "back <-" icon? |
74d41be
to
463cd10
Compare
@tobiasKaminsky After this changes we don't need inheritance of DrawerActivity. Back button added and code is decoupled. df9bdac Demo fixed.mp4 |
6ea13b3
to
cbd049d
Compare
@alperozturk96 can you test it with a notification? 😨 |
Seems like after shifting top layout, it's not looking good. I will check it today. |
Signed-off-by: tobiasKaminsky <[email protected]>
Signed-off-by: tobiasKaminsky <[email protected]>
Signed-off-by: tobiasKaminsky <[email protected]>
Signed-off-by: tobiasKaminsky <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
d1e227e
to
f5dc72a
Compare
@tobiasKaminsky Now, it should look good for both low-resolution and high-resolution devices, whether there is a notification present or not. 1.mp42.mp4 |
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: tobiasKaminsky <[email protected]>
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13610.apk |
For #13051