-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature - Auto Rename #13583
Merged
Merged
Feature - Auto Rename #13583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alperozturk96
force-pushed
the
feature/auto-rename
branch
2 times, most recently
from
September 19, 2024 15:42
4da3289
to
99d505a
Compare
I tested it like this
|
alperozturk96
force-pushed
the
feature/auto-rename
branch
4 times, most recently
from
September 24, 2024 08:42
4c98afd
to
4aab09f
Compare
alperozturk96
force-pushed
the
feature/auto-rename
branch
2 times, most recently
from
September 25, 2024 14:09
33040c7
to
bf09a72
Compare
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
…test Signed-off-by: alperozturk <[email protected]>
…0 and above Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
alperozturk96
force-pushed
the
feature/auto-rename
branch
from
September 26, 2024 07:56
fe7400a
to
401b67e
Compare
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13583.apk |
As dicsussed it is ok to have no thumbnails for renamed uploads, as this is very tricky. |
tobiasKaminsky
approved these changes
Sep 30, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo
Screen.Recording.2024-09-24.at.14.52.49.mp4
How to Test?
Enable Windows file compatibility capability
Attempt to upload files with invalid filenames. You can refer to the
AutoRenameTests
class for guidance.Ensure the filenames are renamed according to the requirements outlined in this issue.
Try uploading the same files to an encrypted folder.