Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - Auto Rename #13583

Merged
merged 27 commits into from
Sep 30, 2024
Merged

Feature - Auto Rename #13583

merged 27 commits into from
Sep 30, 2024

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Sep 17, 2024

  • Tests written, or not not needed

Demo

Screen.Recording.2024-09-24.at.14.52.49.mp4

How to Test?

  1. Enable Windows file compatibility capability

  2. Attempt to upload files with invalid filenames. You can refer to the AutoRenameTests class for guidance.

  3. Ensure the filenames are renamed according to the requirements outlined in this issue.

  4. Try uploading the same files to an encrypted folder.

@alperozturk96 alperozturk96 changed the title Feature - Auto ename Feature - Auto Rename Sep 17, 2024
@alperozturk96 alperozturk96 marked this pull request as draft September 17, 2024 14:55
@alperozturk96 alperozturk96 force-pushed the feature/auto-rename branch 2 times, most recently from 4da3289 to 99d505a Compare September 19, 2024 15:42
@alperozturk96 alperozturk96 marked this pull request as ready for review September 19, 2024 15:42
@tobiasKaminsky
Copy link
Member

I tested it like this

  • create 1:1.jpg
  • go to Files app (Android's browser)
  • share the file to NC
    --> no auto rename

@alperozturk96 alperozturk96 force-pushed the feature/auto-rename branch 4 times, most recently from 4c98afd to 4aab09f Compare September 24, 2024 08:42
@tobiasKaminsky
Copy link
Member

image

both were renamed and uploaded.
But now they miss their thumbnails.

@alperozturk96 alperozturk96 force-pushed the feature/auto-rename branch 2 times, most recently from 33040c7 to bf09a72 Compare September 25, 2024 14:09
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Copy link

Codacy

Lint

TypemasterPR
Warnings5959
Errors33

SpotBugs

CategoryBaseNew
Bad practice6464
Correctness6363
Dodgy code297296
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness66
Performance5353
Security1818
Total510509

Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13583.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@tobiasKaminsky
Copy link
Member

As dicsussed it is ok to have no thumbnails for renamed uploads, as this is very tricky.

@tobiasKaminsky tobiasKaminsky merged commit 348bc9e into master Sep 30, 2024
21 checks passed
@tobiasKaminsky tobiasKaminsky deleted the feature/auto-rename branch September 30, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants