Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ANR During Uploads #13578

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Fix ANR During Uploads #13578

merged 1 commit into from
Sep 19, 2024

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Sep 16, 2024

  • Tests written, or not not needed

Problem?

getUploadByRemotePath() was running on main thread and causing ANR

Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13578.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Copy link

Codacy

Lint

TypemasterPR
Warnings5959
Errors33

SpotBugs

CategoryBaseNew
Bad practice6464
Correctness6363
Dodgy code297297
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness66
Performance5353
Security1818
Total510510

@alperozturk96 alperozturk96 merged commit 2145f52 into master Sep 19, 2024
22 checks passed
@alperozturk96 alperozturk96 deleted the fix/anr-during-file-upload branch September 19, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants