Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix - Loading Dialog Must Run On Main Thread #13556

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Sep 12, 2024

  • Tests written, or not not needed

How to reproduce?

  1. Have encrypted folder in app
  2. Set passcode
  3. Open web panel reset encryption and select delete all encrypted folder
  4. Pull-to-refresh from the app

or

  1. Try to create folder multiple times

This bug introduced with #13551.

While testing the previous PR, I didn’t encounter any issues. However, when I tried to trigger the loading dialog multiple times in quick succession—such as by attempting to create new folders repeatedly—the following exception occurred.

java.lang.IllegalStateException: Must be called from main thread of fragment host at FileActivity.showLoadingDialog().

Signed-off-by: alperozturk <[email protected]>
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13556.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@alperozturk96 alperozturk96 changed the title BugFix - Loading Dialog Run On UI Thread BugFix - Loading Dialog Must Run On Main Thread Sep 12, 2024
Copy link

Codacy

Lint

TypemasterPR
Warnings5959
Errors33

SpotBugs

CategoryBaseNew
Bad practice6464
Correctness6363
Dodgy code297297
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness66
Performance5353
Security1818
Total510510

@alperozturk96 alperozturk96 merged commit 9c590e6 into master Sep 13, 2024
22 checks passed
@alperozturk96 alperozturk96 deleted the bugfix/fix-thread-issue-for-dialog branch September 13, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants