Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix - Check Filename Limitation With Correct Server Version and Configuration #13552

Merged
merged 9 commits into from
Sep 12, 2024

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Sep 11, 2024

  • Tests written, or not not needed

What does this PR?

  • Allow folder creation/renaming with trailing spaces or periods if no WCF config is present.
  • Enforce WCF rules (e.g., forbidden file extensions, reserved file names) when WCF configs exist.
  • Improve feedback messages: remove "." from translations and use OCCapability to display forbidden file extensions, eliminating string manipulation.
  • Uses lowercase for comparison in any case
  • Updates tests according to correct NC versions

Acceptance Criteria

  • For NC versions below 30, no checks are performed.
  • For versions 30 and above with WCF, OC capability checks are applied.
  • File emptiness and duplicate filename checks are always enforced, regardless of version or limitations.

Signed-off-by: alperozturk <[email protected]>
@nextcloud nextcloud deleted a comment from github-actions bot Sep 11, 2024
Copy link

Codacy

Lint

TypemasterPR
Warnings5959
Errors33

SpotBugs

CategoryBaseNew
Bad practice6363
Correctness6464
Dodgy code299299
Experimental11
Internationalization77
Multithreaded correctness66
Performance5353
Security1818
Total511511

Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13552.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@alperozturk96 alperozturk96 merged commit 2f4dcbd into master Sep 12, 2024
21 checks passed
@alperozturk96 alperozturk96 deleted the bugfix/wcf-limitations branch September 12, 2024 12:46
@alperozturk96
Copy link
Collaborator Author

/backport to stable-3.30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants