Do not allow multiple instances of LoadingDialog #13551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZetaTom
force-pushed
the
fix/loading_dialogue_dismiss
branch
from
66a272f
to
74ad420
Compare
alperozturk96
approved these changes
Sep 11, 2024
|
Tested working |
alperozturk96
force-pushed
the
fix/loading_dialogue_dismiss
branch
from
74ad420
to
7053670
Compare
Signed-off-by: ZetaTom <[email protected]>
ZetaTom
force-pushed
the
fix/loading_dialogue_dismiss
branch
from
7053670
to
89d6cf3
Compare
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13551.apk |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change reintroduces more robust state handling when creating new loading dialogues. Previously it was possible to create multiple instances by issuing successive calls to
showLoadingDialog(). Because of this one or more instances could end up stuck on screen, requiring a restart of the app.Testing these changes:
With this change, the dialogue should eventually disappear.