Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextWebView: allow to upload multiple attachements #13546

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Sep 10, 2024

  • Tests written, or not not needed

@juliusknorr
Copy link
Member

Since Stephan pinged me on this, cannot really judge on the code but Arthur gave it a test run and confirmed that it works

Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13546.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Copy link

Codacy

Lint

TypemasterPR
Warnings5959
Errors33

SpotBugs

CategoryBaseNew
Bad practice6464
Correctness6363
Dodgy code297297
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness66
Performance5353
Security1818
Total510510

Copy link
Collaborator

@alperozturk96 alperozturk96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I try to open an .md file, the TextEditorWebView (which inherits from EditorWebView) gets called. I add multiple attachments to the .md file, they are added successfully, which triggers the else block without any issues.

@tobiasKaminsky tobiasKaminsky merged commit 84d4fae into master Oct 2, 2024
17 of 21 checks passed
@tobiasKaminsky tobiasKaminsky deleted the textAttachements branch October 2, 2024 12:07
@alperozturk96
Copy link
Collaborator

/backport to stable-3.30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants