Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BugFix - E2E Solve File Conflict NPE #13514

Merged
merged 1 commit into from
Sep 18, 2024
Merged

BugFix - E2E Solve File Conflict NPE #13514

merged 1 commit into from
Sep 18, 2024

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Sep 4, 2024 •
edited
Loading

  • Tests written, or not not needed

@alperozturk96 alperozturk96 marked this pull request as draft September 4, 2024 13:54
@alperozturk96 alperozturk96 marked this pull request as ready for review September 5, 2024 07:35
@alperozturk96 alperozturk96 force-pushed the bugfix/npe-e2e-conflict-resolve branch 3 times, most recently from ae274c7 to 46b8396 Compare September 12, 2024 10:04
@alperozturk96 alperozturk96 marked this pull request as draft September 12, 2024 10:04
@alperozturk96 alperozturk96 marked this pull request as ready for review September 17, 2024 07:29
@github-actions GitHub Actions
Copy link

Codacy

Lint

TypemasterPR
Warnings5959
Errors33

SpotBugs

CategoryBaseNew
Bad practice6464
Correctness6363
Dodgy code297297
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness66
Performance5353
Security1818
Total510510

@github-actions GitHub Actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13514.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@ZetaTom ZetaTom merged commit 74fe8cf into master Sep 18, 2024
21 checks passed
@ZetaTom ZetaTom deleted the bugfix/npe-e2e-conflict-resolve branch September 18, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZetaTom ZetaTom ZetaTom approved these changes

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alperozturk96 @ZetaTom