Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] Attach snackbar only to respective fragment item in viewpager #13512

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

parneet-guraya
Copy link
Contributor

Fixes:
#8054
#7808

Before

Record_2024-09-04-11-13-21.mp4

After

Record_2024-09-04-12-50-57.mp4
  • Use CoordinatorLayout instead of FrameLayout. Snackbar prioritize attaching to that from the view tree. Otherwise, it would attach to the parent view which would show snackbar outside the pager container (unintended).

  • Now passing CoordinatorLayout to only those snackbar messages that needs to be in context of a particular fragment in the pager.

@parneet-guraya parneet-guraya force-pushed the fix-image-pager branch 2 times, most recently from 4af7335 to 743f5bb Compare September 5, 2024 13:50
@parneet-guraya
Copy link
Contributor Author

@alperozturk96 , turns out we don't need to pass the reference CoordinatorLayout as for any child view passed it will anyways look for CoordinatorLayout first. So, removed the redundant changes. just pinging you to tell the change in case you wanna review it again.

Copy link

Codacy

Lint

TypemasterPR
Warnings5959
Errors33

SpotBugs

CategoryBaseNew
Bad practice6363
Correctness6464
Dodgy code299299
Experimental11
Internationalization77
Multithreaded correctness66
Performance5353
Security1818
Total511511

Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13512.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@alperozturk96 alperozturk96 merged commit c5ca19e into master Sep 19, 2024
21 checks passed
@alperozturk96 alperozturk96 deleted the fix-image-pager branch September 19, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants