Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-3.29] BugFix - Check Account Type Before Sync Operation Execution and Instead Crashing The App Inform User #13444

Merged
merged 5 commits into from
Aug 26, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Aug 23, 2024

Backport of #13440

Warning, This backport had conflicts that were resolved with the ours merge strategy and is likely incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot added this to the Nextcloud App 3.29.2 RC1 milestone Aug 23, 2024
@alperozturk96 alperozturk96 modified the milestones: Nextcloud App 3.29.2 RC1, Nextcloud App 3.29.3 Aug 23, 2024
@alperozturk96 alperozturk96 marked this pull request as ready for review August 23, 2024 09:56
Copy link

Lint

Typestable-3.29PR
Warnings6969
Errors33

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness7171
Dodgy code340340
Experimental11
Internationalization77
Multithreaded correctness66
Performance5757
Security1919
Total566566

Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13444.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@AndyScherzinger AndyScherzinger merged commit 746ab30 into stable-3.29 Aug 26, 2024
4 of 5 checks passed
@AndyScherzinger AndyScherzinger deleted the backport/13440/stable-3.29 branch August 26, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants