Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature - Create Folder When Device Don't Have Internet Connection #13408

Merged
merged 104 commits into from
Sep 4, 2024
Merged

Feature - Create Folder When Device Don't Have Internet Connection #13408

merged 104 commits into from
Sep 4, 2024

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Aug 12, 2024 •
edited
Loading

  • Tests written, or not not needed

@alperozturk96 alperozturk96 marked this pull request as draft August 12, 2024 10:25
@alperozturk96 alperozturk96 force-pushed the feature/offline-create-folder-operation branch 5 times, most recently from 99e7b99 to 8f9e8e2 Compare August 20, 2024 08:33
@alperozturk96 alperozturk96 force-pushed the feature/offline-create-folder-operation branch 2 times, most recently from 14e6b75 to 26e61b2 Compare August 22, 2024 12:41
@alperozturk96
Copy link
Collaborator Author

/rebase

@alperozturk96 alperozturk96 force-pushed the feature/offline-create-folder-operation branch from b4c59fe to b679c20 Compare August 27, 2024 08:31
@alperozturk96 alperozturk96 marked this pull request as ready for review August 27, 2024 09:16
@alperozturk96 alperozturk96 force-pushed the feature/offline-create-folder-operation branch 2 times, most recently from 864c58d to e32f2b3 Compare August 30, 2024 07:10
@alperozturk96 alperozturk96 force-pushed the feature/offline-create-folder-operation branch 2 times, most recently from 45eb521 to c7fc923 Compare September 2, 2024 07:35
@alperozturk96
Dont show if any file is offline
85582d4 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Fix parent path finding
a9e3ef9 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Update sub-directories after rename
5fcebae 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Cleanup extensions
d779ee1 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
try id
883897e 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Add getAllSubdirectories
25679b3 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Remove top dir checks
07db2f0 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Remove path checks for deleteOperation
dd36d0b 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Remove extension tests
1f58ef1 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Remove path manipulation for rename
2011f6a 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Fix duplicated old dir recreation after rename
9913519 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Use repository instead extensions
ed7a1bf 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Faster currentDir refresh
f0179d8 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Fix keep both without path manipulation
3812f8c 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Fix listDirectory call
c748184 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Only update necessary sub-dirs
6af4c3c 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
apply KT Spotless
4eda0ef 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
performance optimization
05b0ab0 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Fix code analytics
c59a3ea 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
handle while loop better
212edbf 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Fix kotlin spotless check
abc85a8 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 alperozturk96 force-pushed the feature/offline-create-folder-operation branch from c7fc923 to abc85a8 Compare September 3, 2024 10:09
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024

Codacy

Lint

TypemasterPR
Warnings6060
Errors33

SpotBugs

CategoryBaseNew
Bad practice6363
Correctness6464
Dodgy code300300
Experimental11
Internationalization77
Multithreaded correctness66
Performance5353
Security1818
Total512512

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13408.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@AndyScherzinger AndyScherzinger merged commit 8f42be4 into master Sep 4, 2024
17 of 21 checks passed
@AndyScherzinger AndyScherzinger deleted the feature/offline-create-folder-operation branch September 4, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

@AndyScherzinger AndyScherzinger Awaiting requested review from AndyScherzinger

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alperozturk96 @AndyScherzinger