Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comments loading and screenshot test #12474

Merged
merged 8 commits into from
Feb 12, 2024
Merged

Conversation

ZetaTom
Copy link
Collaborator

@ZetaTom ZetaTom commented Jan 31, 2024

This pull request serves two purposes. First, it fixes the never ending loading screen when accessing the comments tab of any given file. Secondly, it introduces a check, whose absence lead to the FileDetailFragmentStaticServerIT test failing.


  • Tests written, or not not needed

@ZetaTom
Copy link
Collaborator Author

ZetaTom commented Jan 31, 2024

@tobiasKaminsky, please check that all tests work as expected and add new ones if necessary.

@ZetaTom ZetaTom mentioned this pull request Jan 31, 2024
1 task
@joshtrichards
Copy link
Member

Fixes #12364

@joshtrichards joshtrichards linked an issue Jan 31, 2024 that may be closed by this pull request
Copy link
Collaborator

@JonasMayerDev JonasMayerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my brief testing, the issue seems solved.

@tobiasKaminsky
Copy link
Member

/backport to stable-3.28

ZetaTom and others added 2 commits February 12, 2024 13:43
Signed-off-by: Andy Scherzinger <[email protected]>
Copy link

Codacy

Lint

TypemasterPR
Warnings6969
Errors33

SpotBugs

CategoryBaseNew
Bad practice6868
Correctness7373
Dodgy code357357
Experimental22
Internationalization77
Malicious code vulnerability22
Multithreaded correctness66
Performance5656
Security1818
Total589589

Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12474.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.29.0 milestone Feb 12, 2024
@AndyScherzinger AndyScherzinger merged commit 734002e into master Feb 12, 2024
20 checks passed
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File activity does not show up
5 participants