-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix comments loading and screenshot test #12474
Conversation
@tobiasKaminsky, please check that all tests work as expected and add new ones if necessary. |
Fixes #12364 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my brief testing, the issue seems solved.
/backport to stable-3.28 |
6e08675
to
b3d80cb
Compare
97e0ef1
to
c799c41
Compare
efc85c5
to
dafb395
Compare
Signed-off-by: ZetaTom <[email protected]>
Signed-off-by: ZetaTom <[email protected]>
Signed-off-by: tobiasKaminsky <[email protected]>
Signed-off-by: tobiasKaminsky <[email protected]>
Signed-off-by: ZetaTom <[email protected]>
Signed-off-by: ZetaTom <[email protected]>
e512aaf
to
aabf6d4
Compare
Signed-off-by: ZetaTom <[email protected]>
Signed-off-by: Andy Scherzinger <[email protected]>
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12474.apk |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
This pull request serves two purposes. First, it fixes the never ending loading screen when accessing the comments tab of any given file. Secondly, it introduces a check, whose absence lead to the
FileDetailFragmentStaticServerIT
test failing.