Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix screenshot test #12402

Closed
wants to merge 1 commit into from
Closed

Fix screenshot test #12402

wants to merge 1 commit into from

Conversation

ZetaTom
Copy link
Collaborator

@ZetaTom ZetaTom commented Jan 22, 2024

This change fixes screenshot tests failing because the following trace:

java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String com.owncloud.android.datamodel.OCFile.getRemotePath()' on a null object reference

at com.owncloud.android.ui.fragment.FileDetailSharingFragment.refreshSharesFromDB(FileDetailSharingFragment.java:465)

at com.owncloud.android.ui.fragment.FileDetailSharingFragment.onActivityCreated(FileDetailSharingFragment.java:159)

at androidx.fragment.app.Fragment.performActivityCreated(Fragment.java:3156)
...
  • Tests written, or not not needed

Signed-off-by: ZetaTom <[email protected]>
Copy link

Codacy

Lint

TypemasterPR
Warnings6969
Errors33

SpotBugs

CategoryBaseNew
Bad practice2626
Correctness7373
Dodgy code360360
Experimental22
Internationalization77
Malicious code vulnerability22
Multithreaded correctness66
Performance5454
Security1818
Total548548

Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12402.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Copy link

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@ZetaTom
Copy link
Collaborator Author

ZetaTom commented Jan 31, 2024

Superseded by #12474.

@ZetaTom ZetaTom closed this Jan 31, 2024
@ZetaTom ZetaTom deleted the fix/screenshot-test branch January 31, 2024 09:07
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant