Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misleading toast in uploads tab #12316

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

JonasMayerDev
Copy link
Collaborator

Fix info toast showing every time uploads tab is refreshed, even if no files are actually retried.

  • Tests written, or not not needed

@JonasMayerDev JonasMayerDev force-pushed the missleading_error_toast_in_uploads_tab branch from 7cd5d43 to cd3bdde Compare December 21, 2023 16:14
Copy link

Codacy

Lint

TypemasterPR
Warnings6969
Errors33

SpotBugs

CategoryBaseNew
Bad practice2626
Correctness6969
Dodgy code354354
Experimental22
Internationalization99
Malicious code vulnerability22
Multithreaded correctness99
Performance5454
Security1818
Total543543

Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12316.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@JonasMayerDev JonasMayerDev merged commit c612d7a into master Dec 21, 2023
20 checks passed
@delete-merged-branch delete-merged-branch bot deleted the missleading_error_toast_in_uploads_tab branch December 21, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants