Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle audio focus and becoming noisy #12310

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Conversation

parneet-guraya
Copy link
Contributor

  • Handle Audio focus
  • Handle Audio becoming noisy

Handle audio focus -->

Record_2023-12-20-19-50-25.mp4

The player will handle the audio focus shifts. Basically It would:

  • Pause the already playing media when this player is started.
  • Or If some other media starts this player would pause itself.
    This would avoid two media's playing at the same time.

Handle audio becoming noisy -->

Record_2023-12-20-19-50-54.mp4

When a headset is unplugged or a Bluetooth device disconnected, the audio stream automatically reroutes to the built-in speaker. If you listen to music at a high volume, this can be a noisy surprise.

Users usually expect apps that include a music player with onscreen playback controls to pause playback in this case. Other apps, like games that don't include controls, should keep playing. The user can adjust the volume with the device's hardware controls.

See More

You can see here after turning of bluetooth the playback pauses.

@alperozturk96
Copy link
Collaborator

@parneet-guraya Could you fix "spotlessKotlinCheck" ?

@parneet-guraya
Copy link
Contributor Author

@parneet-guraya Could you fix "spotlessKotlinCheck" ?

done 👍

@alperozturk96
Copy link
Collaborator

@parneet-guraya Media3 PR merged. Could you check with latest implementation?

@parneet-guraya
Copy link
Contributor Author

Looking into it 👍

Copy link

github-actions bot commented Jan 9, 2024

Codacy

Lint

TypemasterPR
Warnings6969
Errors33

SpotBugs

CategoryBaseNew
Bad practice2626
Correctness6969
Dodgy code353353
Experimental22
Internationalization99
Malicious code vulnerability22
Multithreaded correctness99
Performance5454
Security1818
Total542542

Copy link

github-actions bot commented Jan 9, 2024

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12310.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@alperozturk96 alperozturk96 merged commit fb3694f into master Jan 10, 2024
20 checks passed
@delete-merged-branch delete-merged-branch bot deleted the handle-audio-focus branch January 10, 2024 08:51
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants