Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add exclude hidden file or folder option when create custom media folder type #12297

Conversation

BBBOND
Copy link
Contributor

@BBBOND BBBOND commented Dec 15, 2023

  • Tests written, or not not needed

Adding a synchronization directory of custom file types will synchronize all files to the cloud. However, many useless hidden files are often written into the directory by third-party software, causing conflicts in synchronization. Therefore, an option to exclude hidden files has been added. to solve this problem.

iShot_2023-12-15_22 02 35

@BBBOND BBBOND marked this pull request as draft December 16, 2023 01:33
@BBBOND BBBOND marked this pull request as ready for review December 16, 2023 01:33
@BBBOND
Copy link
Contributor Author

BBBOND commented Dec 16, 2023

Anyone who can tell me how to add feature to this project?

…folder-option-when-create-custom-media-folder-type

Feature/add exclude hidden file or folder option when create custom media folder type
@AndyScherzinger AndyScherzinger force-pushed the feature/add-exclude-hidden-file-or-folder-option-when-create-custom-media-folder-type branch from 2631bc5 to 619ddb9 Compare December 19, 2023 11:03
@BBBOND BBBOND force-pushed the feature/add-exclude-hidden-file-or-folder-option-when-create-custom-media-folder-type branch 2 times, most recently from 555a1ab to 642287b Compare December 21, 2023 13:06
@BBBOND BBBOND force-pushed the feature/add-exclude-hidden-file-or-folder-option-when-create-custom-media-folder-type branch from 642287b to d274dca Compare December 21, 2023 15:02
@BBBOND BBBOND force-pushed the feature/add-exclude-hidden-file-or-folder-option-when-create-custom-media-folder-type branch from d274dca to b0051d3 Compare December 22, 2023 01:46
BBBOND and others added 5 commits December 22, 2023 09:46
…or-folder-option-when-create-custom-media-folder-type' into feature/add-exclude-hidden-file-or-folder-option-when-create-custom-media-folder-type
…option-when-create-custom-media-folder-type

# Conflicts:
#	app/src/main/res/values-zh-rCN/strings.xml
…onfig/master

🔄 synced file(s) with nextcloud/android-config
@AndyScherzinger
Copy link
Member

@BBBOND best to rebase against master instead of merging the master changes. Else you pollute the PR with commits not part of the PR originally.

alperozturk96 and others added 25 commits December 22, 2023 19:11
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: JinWeiyang <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: JinWeiyang <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: JinWeiyang <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: JinWeiyang <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: JinWeiyang <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: JinWeiyang <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: JinWeiyang <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: JinWeiyang <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: JinWeiyang <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: JinWeiyang <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: JinWeiyang <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: JinWeiyang <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: JinWeiyang <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: JinWeiyang <[email protected]>
Signed-off-by: Jonas Mayer <[email protected]>
Signed-off-by: JinWeiyang <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: JinWeiyang <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: JinWeiyang <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: JinWeiyang <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: JinWeiyang <[email protected]>
…or-folder-option-when-create-custom-media-folder-type' into feature/add-exclude-hidden-file-or-folder-option-when-create-custom-media-folder-type
@BBBOND
Copy link
Contributor Author

BBBOND commented Dec 22, 2023

@AndyScherzinger Sorry, I seem to have made a mistake in this PR. Let me create it again.

@BBBOND BBBOND closed this Dec 22, 2023
@BBBOND BBBOND deleted the feature/add-exclude-hidden-file-or-folder-option-when-create-custom-media-folder-type branch December 22, 2023 11:17
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants