Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Deprecated Argument Passing #12287

Merged
merged 26 commits into from
Dec 19, 2023
Merged

Replace Deprecated Argument Passing #12287

merged 26 commits into from
Dec 19, 2023

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Dec 13, 2023 •
edited
Loading

  • Tests written, or not not needed

@alperozturk96
Copy link
Collaborator Author

/rebase

@nextcloud-command nextcloud-command force-pushed the refactor/remove-deprecated-argument-passing branch from 3a46e68 to 2d64720 Compare December 14, 2023 13:05
@tobiasKaminsky
Copy link
Member

@alperozturk96 did a smoke test and it works.
Can you rebase it to master before we merge it?
I think then it is way cleaner for other PRs.

@alperozturk96
Copy link
Collaborator Author

/rebase

ZetaTom
ZetaTom reviewed Dec 18, 2023
View reviewed changes
Copy link
Collaborator

@ZetaTom ZetaTom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general it works well, I haven't come across any breaking changes. The comments I've left are mostly minor changes.

app/src/main/java/com/owncloud/android/ui/activity/SyncedFoldersActivity.kt Outdated Show resolved Hide resolved
app/src/main/java/com/owncloud/android/ui/fragment/OCFileListFragment.java Outdated Show resolved Hide resolved
app/src/main/java/com/owncloud/android/ui/fragment/OCFileListFragment.java Outdated Show resolved Hide resolved
app/src/main/java/com/owncloud/android/ui/fragment/OCFileListFragment.java Outdated Show resolved Hide resolved
app/src/main/java/com/owncloud/android/ui/fragment/OCFileListFragment.java Outdated Show resolved Hide resolved
app/src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.java Outdated Show resolved Hide resolved
app/src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.java Outdated Show resolved Hide resolved
app/src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.java Outdated Show resolved Hide resolved
app/src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.java Outdated Show resolved Hide resolved
@alperozturk96 alperozturk96 force-pushed the refactor/remove-deprecated-argument-passing branch from 92b4498 to 357f301 Compare December 18, 2023 10:43
@alperozturk96
Copy link
Collaborator Author

@ZetaTom Suggested changes applied. Please review again

@alperozturk96
Copy link
Collaborator Author

/rebase

alperozturk96 and others added 15 commits December 18, 2023 14:47
@alperozturk96
Replace deprecated usages
868da5b 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Replace deprecated usages
0ba2a68 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Replace deprecated usages
d01991e 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Analysis: update lint results to reflect reduced error/warning count
b4f60f6 
Signed-off-by: github-actions <[email protected]>
@alperozturk96
Reduce dodgy codes
ec3be74 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Reduce dodgy code
10c564d 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Fix merge conflicts
1b399b2 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Fix merge conflicts
32fd626 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Rebase master
1973a20 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Rebase master
b37f00e 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Optimize imports
e9e425d 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Optimize imports
da6477f 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Rebase master
5aeac16 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Rebase master
03114c1 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Rebase master
fae5f69 
Signed-off-by: alperozturk <[email protected]>
alperozturk96 and others added 11 commits December 18, 2023 14:47
@alperozturk96
Optimize imports
4483ca1 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Optimize imports
e8ff038 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 @ZetaTom
Update app/src/main/java/com/owncloud/android/ui/fragment/OCFileListF…
b980f55 
…ragment.java

Co-authored-by: Tom <[email protected]>
Signed-off-by: Alper Öztürk <[email protected]>
@alperozturk96 @ZetaTom
Update app/src/main/java/com/owncloud/android/ui/activity/SyncedFolde…
ea013b0 
…rsActivity.kt

Co-authored-by: Tom <[email protected]>
Signed-off-by: Alper Öztürk <[email protected]>
@alperozturk96 @ZetaTom
Update app/src/main/java/com/owncloud/android/ui/fragment/OCFileListF…
5ff5d60 
…ragment.java

Co-authored-by: Tom <[email protected]>
Signed-off-by: Alper Öztürk <[email protected]>
@alperozturk96 @ZetaTom
Update app/src/main/java/com/owncloud/android/ui/activity/FileDisplay…
61251b6 
…Activity.java

Co-authored-by: Tom <[email protected]>
Signed-off-by: Alper Öztürk <[email protected]>
@alperozturk96 @ZetaTom
Update app/src/main/java/com/owncloud/android/ui/activity/FileDisplay…
6718a36 
…Activity.java

Co-authored-by: Tom <[email protected]>
Signed-off-by: Alper Öztürk <[email protected]>
@alperozturk96 @ZetaTom
Update app/src/main/java/com/owncloud/android/ui/activity/FileDisplay…
cb329b1 
…Activity.java

Co-authored-by: Tom <[email protected]>
Signed-off-by: Alper Öztürk <[email protected]>
@alperozturk96 @ZetaTom
Update app/src/main/java/com/owncloud/android/ui/fragment/OCFileListF…
9874673 
…ragment.java

Co-authored-by: Tom <[email protected]>
Signed-off-by: Alper Öztürk <[email protected]>
@alperozturk96 @ZetaTom
Update app/src/main/java/com/owncloud/android/ui/fragment/OCFileListF…
8c43463 
…ragment.java

Co-authored-by: Tom <[email protected]>
Signed-off-by: Alper Öztürk <[email protected]>
@alperozturk96 @ZetaTom
Update app/src/main/java/com/owncloud/android/ui/activity/FileDisplay…
224c2e6 
…Activity.java


I tested. Looks like not needed.

Co-authored-by: Tom <[email protected]>
Signed-off-by: Alper Öztürk <[email protected]>
@nextcloud-command nextcloud-command force-pushed the refactor/remove-deprecated-argument-passing branch from a6b4a85 to 224c2e6 Compare December 18, 2023 14:47
@github-actions GitHub Actions
Copy link

Codacy

Lint

TypemasterPR
Warnings7069
Errors33

SpotBugs

CategoryBaseNew
Bad practice2626
Correctness6869
Dodgy code360354
Experimental22
Internationalization99
Malicious code vulnerability22
Multithreaded correctness99
Performance5454
Security1818
Total548543

@github-actions GitHub Actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12287.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions GitHub Actions
Copy link

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@tobiasKaminsky tobiasKaminsky merged commit f430bf1 into master Dec 19, 2023
18 of 20 checks passed
@delete-merged-branch delete-merged-branch bot deleted the refactor/remove-deprecated-argument-passing branch December 19, 2023 06:59
@ZetaTom ZetaTom mentioned this pull request Dec 20, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZetaTom ZetaTom ZetaTom approved these changes

@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes

@JonasMayerDev JonasMayerDev Awaiting requested review from JonasMayerDev

@AndyScherzinger AndyScherzinger Awaiting requested review from AndyScherzinger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alperozturk96 @tobiasKaminsky @ZetaTom