Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UI drawer overlapping #11337 #12261

Closed
wants to merge 4 commits into from
Closed

Fix UI drawer overlapping #11337 #12261

wants to merge 4 commits into from

Conversation

satvik2131
Copy link

@satvik2131 satvik2131 commented Dec 10, 2023

I have added appbar color as backround , suggest me any changes if there is required ?
Screenshot 2023-12-10 125916

Copy link
Collaborator

@ZetaTom ZetaTom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Firstly, thank you for taking the time to suggest and implement a fix for this problem.

At first glance, the solution seems to be working. Upon closer inspection, I noticed a slight colour mismatch between the background colour of the navbar and @color/appbar.

Also, please remove any changes not related to this issue from this pull request, such as those in PreviewImageFragment, as this will make the review process easier. Feel free to open a separate pull request for those changes.

See #11336

@satvik2131
Copy link
Author

Hi @ZetaTom what should be good changing the background color or making it aligned at the bottom only , so that if we scroll up we won't see it ?

@satvik2131 satvik2131 closed this Dec 11, 2023
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants