enh/connectionChecks: Report main reason + don't do unnecessary checks #12260
Conversation
|
/rebase |
joshtrichards
force-pushed
the
enh/connectionChecks
branch
from
290a147
to
b9c3d31
Compare
Previously checkConditions() would always report the last detected condition (in the method) that prevented the upload rather than the first. Besides doing unnecessary work, this meant that situations where say the auto-upload condition is set to "charging only" but network connectivity isn't working, would be reported as "Upload failed" due to a "Connection error" which is irrelevant. Also means we stop doing silling things like checking for network connectivity when the upload is already excluded due to the device not currently charging. Signed-off-by: Josh Richards <[email protected]>
joshtrichards
force-pushed
the
enh/connectionChecks
branch
from
b9c3d31
to
dcff63d
Compare
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12260.apk |
|
test-Unit test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/12260-Unit-test-01-58 |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
WIP - still testing
Previously checkConditions() would always report the last detected condition (in the method) that prevented the upload rather than the first. Besides doing unnecessary work, this meant that situations where say the auto-upload condition is set to "charging only" but network connectivity isn't working, would be reported as "Upload failed" due to a "Connection error" which is irrelevant. Also means we stop doing silling things like checking for network connectivity when the upload is already excluded due to the device not currently charging.
Probably fixes #10336 among other general UX complaints about how notifications happen unnecessarily.