Convert ChooseRichDocumentsTemplateDialogFragment to Kotlin #12183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
alperozturk96
commented
Nov 17, 2023
•
alperozturk96
commented
- Tests written, or not not needed
alperozturk96
requested review from
AndyScherzinger,
tobiasKaminsky and
ZetaTom
|
/rebase |
nextcloud-command
force-pushed
the
refactor/convert-ChooseRichDocumentsTemplateDialogFragment-to-kt
branch
from
7e0ea94
to
197f787
Compare
|
/rebase |
nextcloud-command
force-pushed
the
refactor/convert-ChooseRichDocumentsTemplateDialogFragment-to-kt
branch
from
4211e39
to
22b3232
Compare
|
/rebase |
nextcloud-command
force-pushed
the
refactor/convert-ChooseRichDocumentsTemplateDialogFragment-to-kt
branch
from
22b3232
to
285d9df
Compare
|
gplay variant is working but somehow in tests it fails. |
AndyScherzinger
force-pushed
the
refactor/convert-ChooseRichDocumentsTemplateDialogFragment-to-kt
branch
from
694e632
to
7d5283c
Compare
|
@tobiasKaminsky I wanted to test it but master doesn't show the chooser at all in contrast to web. |
AndyScherzinger
force-pushed
the
refactor/convert-ChooseRichDocumentsTemplateDialogFragment-to-kt
branch
from
1c4f957
to
9261204
Compare
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12183.apk |
tobiasKaminsky
force-pushed
the
refactor/convert-ChooseRichDocumentsTemplateDialogFragment-to-kt
branch
from
138d607
to
9d35b2c
Compare
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
alperozturk96
force-pushed
the
refactor/convert-ChooseRichDocumentsTemplateDialogFragment-to-kt
branch
from
9d35b2c
to
1fe72fd
Compare
|
/rebase |
|
test-Unit test failed, but no output was generated. Maybe a preliminary stage failed. |
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
|
Out of date due to conflicts |
tobiasKaminsky
deleted the
refactor/convert-ChooseRichDocumentsTemplateDialogFragment-to-kt
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.