Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Media Folder to Kotlin #12132

Merged
merged 4 commits into from
Nov 9, 2023
Merged

Convert Media Folder to Kotlin #12132

merged 4 commits into from
Nov 9, 2023

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Nov 3, 2023 •
edited
Loading

  • Tests written, or not not needed

@AndyScherzinger AndyScherzinger force-pushed the refactor/convert-MediaFolder-to-kt branch from b499f76 to fd5df6e Compare November 7, 2023 19:36
@AndyScherzinger AndyScherzinger force-pushed the refactor/convert-MediaFolder-to-kt branch from fd5df6e to 15e015b Compare November 8, 2023 09:42
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

Codacy

Lint

TypemasterPR
Warnings7777
Errors00

SpotBugs

CategoryBaseNew
Bad practice2626
Correctness7272
Dodgy code367365
Experimental22
Internationalization99
Malicious code vulnerability22
Multithreaded correctness99
Performance5858
Security1818
Total563561

@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.27.0 milestone Nov 9, 2023
@AndyScherzinger AndyScherzinger force-pushed the refactor/convert-MediaFolder-to-kt branch from ada9fa7 to 0af3c1d Compare November 9, 2023 15:34
@AndyScherzinger AndyScherzinger merged commit 7b546e3 into master Nov 9, 2023
16 of 18 checks passed
@delete-merged-branch delete-merged-branch bot deleted the refactor/convert-MediaFolder-to-kt branch November 9, 2023 15:34
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12132.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
Nextcloud App 3.27.0
Development

Successfully merging this pull request may close these issues.
3 participants
@alperozturk96 @AndyScherzinger @tobiasKaminsky