Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Deep Link Login Activity to Kotlin #12131

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Convert Deep Link Login Activity to Kotlin #12131

merged 3 commits into from
Nov 9, 2023

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Nov 3, 2023 •
edited
Loading

  • Tests written, or not not needed

@alperozturk96 @AndyScherzinger
Rename .java to .kt
c7c3475 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 @AndyScherzinger
Convert to kt
3a63747 
Signed-off-by: alperozturk <[email protected]>
@AndyScherzinger AndyScherzinger force-pushed the refactor/convert-DeepLinkLoginActivity-to-kt branch from d987e95 to 3a63747 Compare November 8, 2023 17:45
@alperozturk96
Merge master
a64762a 
Signed-off-by: alperozturk <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/12131-Screenshot-blue-Light-11-28

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

Codacy

Lint

TypemasterPR
Warnings7777
Errors00

SpotBugs

CategoryBaseNew
Bad practice2626
Correctness7272
Dodgy code367367
Experimental22
Internationalization99
Malicious code vulnerability22
Multithreaded correctness99
Performance5858
Security1818
Total563563

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12131.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@AndyScherzinger AndyScherzinger merged commit dece04b into master Nov 9, 2023
17 of 19 checks passed
@delete-merged-branch delete-merged-branch bot deleted the refactor/convert-DeepLinkLoginActivity-to-kt branch November 9, 2023 14:47
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.27.0 milestone Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@ZetaTom ZetaTom Awaiting requested review from ZetaTom

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
Nextcloud App 3.27.0
Development

Successfully merging this pull request may close these issues.
3 participants
@alperozturk96 @AndyScherzinger @tobiasKaminsky