Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Authenticator to Kotlin #12128

Merged
merged 7 commits into from
Mar 19, 2024
Merged

Convert Authenticator to Kotlin #12128

merged 7 commits into from
Mar 19, 2024

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Nov 2, 2023 •
edited
Loading

  • Tests written, or not not needed

@tobiasKaminsky
Copy link
Member

AuthenticatorUrlUtilsTest.java:41: error: non-static method normalizeScheme(String) cannot be referenced from a static context
String normalized = AuthenticatorUrlUtils.normalizeScheme(url);

tobiasKaminsky
tobiasKaminsky previously requested changes Nov 7, 2023
View reviewed changes
Copy link
Member

@tobiasKaminsky tobiasKaminsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing

@AndyScherzinger AndyScherzinger force-pushed the refactor/convert-Authenticator-to-kt branch from ebf53db to 8aba51f Compare November 9, 2023 16:21
@alperozturk96
Copy link
Collaborator Author

@tobiasKaminsky Tests are failing due to (AbstractOnServerIT.java:139)

@tobiasKaminsky
Copy link
Member

/rebase

@nextcloud-command nextcloud-command force-pushed the refactor/convert-Authenticator-to-kt branch from ffbce3c to a2ed88f Compare December 3, 2023 08:19
@alperozturk96 alperozturk96 force-pushed the refactor/convert-Authenticator-to-kt branch from a2ed88f to c1321ac Compare February 22, 2024 08:26
@alperozturk96
Rename .java to .kt
5806b17 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Convert AuthenticatorUrlUtils to kt
a94940a 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Rename .java to .kt
305af05 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Convert AuthenticatorAsyncTask to kt
5756407 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Code cleanup
3010f78 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Fix kotlin spotless check
a2d002a 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Fix kotlin object call
36e02b1 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 alperozturk96 force-pushed the refactor/convert-Authenticator-to-kt branch from c1321ac to 36e02b1 Compare February 23, 2024 07:53
@github-actions GitHub Actions
Copy link

Codacy

Lint

TypemasterPR
Warnings6969
Errors33

SpotBugs

CategoryBaseNew
Bad practice6868
Correctness7271
Dodgy code351352
Experimental22
Internationalization77
Malicious code vulnerability22
Multithreaded correctness66
Performance5656
Security1818
Total582582

@github-actions GitHub Actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12128.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

JonasMayerDev
JonasMayerDev approved these changes Mar 18, 2024
View reviewed changes
Copy link
Collaborator

@JonasMayerDev JonasMayerDev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Login in and app seem to work like on master

JonasMayerDev
JonasMayerDev approved these changes Mar 19, 2024
View reviewed changes
Copy link
Collaborator

@JonasMayerDev JonasMayerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve again since nothing has changed

@alperozturk96 alperozturk96 dismissed tobiasKaminsky’s stale review March 19, 2024 11:59

not valid anymore, resolved

@alperozturk96 alperozturk96 merged commit 1a35df4 into master Mar 19, 2024
20 checks passed
@delete-merged-branch delete-merged-branch bot deleted the refactor/convert-Authenticator-to-kt branch March 19, 2024 11:59
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.29.0 milestone Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonasMayerDev JonasMayerDev JonasMayerDev approved these changes

@AndyScherzinger AndyScherzinger Awaiting requested review from AndyScherzinger

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

@ZetaTom ZetaTom Awaiting requested review from ZetaTom

Assignees
No one assigned
Labels
4. to release
Projects
None yet
Milestone
Nextcloud App 3.29.0
Development

Successfully merging this pull request may close these issues.
4 participants
@alperozturk96 @tobiasKaminsky @JonasMayerDev @AndyScherzinger