Convert AccountAuthenticator to Kotlin #12126
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
alperozturk96
commented
Nov 2, 2023
•
alperozturk96
commented
- Tests written, or not not needed
|
Detekt is failing. |
|
/rebase |
nextcloud-command
force-pushed
the
refactor/convert-AccountAuthenticator-to-kt
branch
from
8abea2a
to
d543f2a
Compare
alperozturk96
requested review from
ZetaTom,
JonasMayerDev and
tobiasKaminsky
|
/rebase |
nextcloud-command
force-pushed
the
refactor/convert-AccountAuthenticator-to-kt
branch
from
d543f2a
to
e53f8e2
Compare
alperozturk96
force-pushed
the
refactor/convert-AccountAuthenticator-to-kt
branch
from
e53f8e2
to
b549906
Compare
alperozturk96
force-pushed
the
refactor/convert-AccountAuthenticator-to-kt
branch
from
b549906
to
944f48f
Compare
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
alperozturk96
force-pushed
the
refactor/convert-AccountAuthenticator-to-kt
branch
from
944f48f
to
2ec36ca
Compare
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12126.apk |
|
blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/12126-Screenshot-blue-Light-08-51 |
|
Out of date due to conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.