Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert WhatsNewActivity to Kotlin #12118

Merged
merged 3 commits into from
Nov 7, 2023
Merged

Convert WhatsNewActivity to Kotlin #12118

merged 3 commits into from
Nov 7, 2023

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Nov 1, 2023 •
edited
Loading

  • Tests written, or not not needed

@AndyScherzinger AndyScherzinger force-pushed the refactor/convert-WhatsNewActivity-to-kt branch from 5b9b4f9 to af86169 Compare November 1, 2023 14:39
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12118.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@AndyScherzinger AndyScherzinger force-pushed the refactor/convert-WhatsNewActivity-to-kt branch from af86169 to 5df58b8 Compare November 1, 2023 22:52
@alperozturk96 @AndyScherzinger
Rename .java to .kt
55dea2c 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 @AndyScherzinger
Convert to kt
b0a90b5 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 @AndyScherzinger
Fix detekt
d87ac3b 
Signed-off-by: alperozturk <[email protected]>
@AndyScherzinger AndyScherzinger force-pushed the refactor/convert-WhatsNewActivity-to-kt branch from 5df58b8 to d87ac3b Compare November 2, 2023 09:51
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2023

Codacy

Lint

TypemasterPR
Warnings7777
Errors00

SpotBugs

CategoryBaseNew
Bad practice2626
Correctness7878
Dodgy code367367
Experimental22
Internationalization99
Malicious code vulnerability22
Multithreaded correctness99
Performance5858
Security1818
Total569569

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2023

blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/12118-Screenshot-blue-Light-11-00

@tobiasKaminsky tobiasKaminsky merged commit 569e5fa into master Nov 7, 2023
15 of 19 checks passed
@delete-merged-branch delete-merged-branch bot deleted the refactor/convert-WhatsNewActivity-to-kt branch November 7, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes

@ZetaTom ZetaTom Awaiting requested review from ZetaTom

@JonasMayerDev JonasMayerDev Awaiting requested review from JonasMayerDev

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alperozturk96 @AndyScherzinger @tobiasKaminsky