Fix missing title in ConfirmationDialogFragment

[ZetaTom]

This change fixes a crash that would occur when attempting to delete any file. (Resources.NotFoundException)

Analysis

The RemoveFilesDialogFragment extends the ConfirmationDialogFragment and thus inherits all methods. Upon instantiation, a an argument bundle is created and set appropriately. This bundle does, however, not include any title for the aforementioned dialogue.

This needs to be considered in the super class, when setting up the ui. A recent change unfortunately removed the necessary check.

---

• Tests written, or not not needed

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12117.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	78	78
Errors	0	0

SpotBugs

Category	Base	New
Bad practice	26	26
Correctness	78	78
Dodgy code	376	376
Experimental	2	2
Internationalization	9	9
Malicious code vulnerability	2	2
Multithreaded correctness	9	9
Performance	56	56
Security	18	18
Total	576	576

[github-actions]

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

[alperozturk96]

@ZetaTom One line solution, fyi

.setTitle(titleId.takeIf { it != 0 && it != -1 } ?: R.string.dialog_alert_title)

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!