Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo error in CONTRIBUTING.md #12116

Merged
merged 1 commit into from
Oct 31, 2023
Merged

fix: typo error in CONTRIBUTING.md #12116

merged 1 commit into from
Oct 31, 2023

Conversation

vivekBoii
Copy link
Contributor

sorry but I dont know to do cahnges in two files and make PR
Hope you understand
New to open Source
practise -> practice

  • Tests written, or not not needed

@AndyScherzinger
Copy link
Member

No worries @vivekBoii all good and thanks again for your contribution.

For adding several changes on several files you would need to create a branch on git commit all changes you like to do to da that branch and when done, create a PR based on that branch. Hope this helps 😊

@AndyScherzinger AndyScherzinger merged commit b040e05 into nextcloud:master Oct 31, 2023
16 of 18 checks passed
Copy link

github-actions bot commented Apr 2, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants