Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert FirstRunActivity to Kotlin #12114

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Convert FirstRunActivity to Kotlin #12114

merged 3 commits into from
Oct 31, 2023

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Oct 31, 2023 •
edited
Loading

  • Tests written, or not not needed

@alperozturk96
Rename .java to .kt
45c1aa7 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Convert to kt
8b74259 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 alperozturk96 changed the title Convert FirstRunActivity to kt Convert FirstRunActivity to Kotlin Oct 31, 2023
@github-actions GitHub Actions
Copy link

Codacy

Lint

TypemasterPR
Warnings7979
Errors00

SpotBugs

CategoryBaseNew
Bad practice2626
Correctness7878
Dodgy code385385
Experimental22
Internationalization99
Malicious code vulnerability22
Multithreaded correctness99
Performance5656
Security1818
Total585585

@github-actions GitHub Actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12114.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions GitHub Actions
Copy link

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@AndyScherzinger AndyScherzinger merged commit 0d9928e into master Oct 31, 2023
18 of 20 checks passed
@delete-merged-branch delete-merged-branch bot deleted the refactor/convert-FirstRunActivity-to-kt branch October 31, 2023 18:45
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.27.0 milestone Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
Nextcloud App 3.27.0
Development

Successfully merging this pull request may close these issues.
2 participants
@alperozturk96 @AndyScherzinger