Build Fix #12111
Merged
Build Fix #12111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
alperozturk96
commented
Oct 31, 2023
•
alperozturk96
commented
- Tests written, or not not needed
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
alperozturk96
commented
Oct 31, 2023
| ) { | ||
| mCurrentDownload!!.cancel() | ||
| } | ||
| mCurrentDownload?.takeIf { |
There was a problem hiding this comment.
Fix This condition is too complex (4). Defined complexity threshold for conditions is set to '4'
alperozturk96
commented
Oct 31, 2023
| if (targetFiles != null) { | ||
| resultData.putParcelableArrayListExtra(EXTRA_FILES, targetFiles) | ||
| } | ||
| when (v) { |
There was a problem hiding this comment.
Fix Function onClick is nested too deeply.
alperozturk96
commented
Oct 31, 2023
| @@ -184,54 +183,75 @@ class FileDownloader : Service(), OnDatatransferProgressListener, OnAccountsUpda | |||
| if (!intent.hasExtra(EXTRA_USER) || !intent.hasExtra(EXTRA_FILE)) { | |||
There was a problem hiding this comment.
Fix Function onStartCommand has 3 return statements which exceeds the limit of 2.
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12111.apk |
delete-merged-branch
bot
deleted the
fix/SyncFileNotEnoughSpaceDialogFragment
branch
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.