Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Deck Api to Kotlin #12110

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Convert Deck Api to Kotlin #12110

merged 2 commits into from
Oct 30, 2023

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Oct 30, 2023 •
edited
Loading

  • Tests written, or not not needed

@alperozturk96
Rename .java to .kt
5b30ec0 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Convert to kt
c57a5e0 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 alperozturk96 changed the title convert deck api impl to kt Convert Deck Api to Kotlin Oct 30, 2023
@github-actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12110.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link

Codacy

Lint

TypemasterPR
Warnings7979
Errors00

SpotBugs

CategoryBaseNew
Bad practice2626
Correctness7979
Dodgy code401401
Experimental22
Internationalization99
Malicious code vulnerability22
Multithreaded correctness99
Performance5858
Security1818
Total604604

@AndyScherzinger AndyScherzinger merged commit 2b42e7d into master Oct 30, 2023
19 of 21 checks passed
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.27.0 milestone Oct 30, 2023
@delete-merged-branch delete-merged-branch bot deleted the refactor/convert-DeckApiImpl-to-kt branch October 30, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@ZetaTom ZetaTom Awaiting requested review from ZetaTom

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
Nextcloud App 3.27.0
Development

Successfully merging this pull request may close these issues.
2 participants
@alperozturk96 @AndyScherzinger