Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed outdated server condition for server version #12105

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

surinder-tsys
Copy link
Collaborator

@surinder-tsys surinder-tsys commented Oct 30, 2023

Fixed server version check condition for the following crash:

  • Tests written, or not not needed

@github-actions
Copy link

Codacy

Lint

TypemasterPR
Warnings7979
Errors00

SpotBugs

CategoryBaseNew
Bad practice2626
Correctness8484
Dodgy code414414
Experimental22
Internationalization99
Malicious code vulnerability22
Multithreaded correctness99
Performance5858
Security1818
Total622622

@github-actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12105.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.27.0 milestone Oct 30, 2023
@AndyScherzinger
Copy link
Member

/backport to stable-3.26

@AndyScherzinger AndyScherzinger merged commit 0dde00e into master Oct 30, 2023
21 checks passed
@delete-merged-branch delete-merged-branch bot deleted the nmc/user_present_check_fix branch October 30, 2023 12:23
Copy link

github-actions bot commented Apr 3, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants