Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert SquareLoaderImageView to Kotlin #12099

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

alperozturk96
Copy link
Collaborator

  • [ Done ] Tests written, or not not needed

Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 alperozturk96 changed the title Convert SquareLoaderImageView to kt Convert SquareLoaderImageView to Kotlin Oct 27, 2023
@github-actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12099.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link

Codacy

Lint

TypemasterPR
Warnings7979
Errors00

SpotBugs

CategoryBaseNew
Bad practice2626
Correctness8484
Dodgy code414414
Experimental22
Internationalization99
Malicious code vulnerability22
Multithreaded correctness99
Performance5858
Security1818
Total622622

@github-actions
Copy link

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@AndyScherzinger AndyScherzinger merged commit 9d5c55b into master Oct 30, 2023
19 of 20 checks passed
@delete-merged-branch delete-merged-branch bot deleted the refactor/convert--SquareLoaderImageView-to-kt branch October 30, 2023 18:24
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.27.0 milestone Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants