Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix Choose Storage Location UI bug 11996 #12098

Merged
merged 4 commits into from
Oct 30, 2023
Merged

Bugfix Choose Storage Location UI bug 11996 #12098

merged 4 commits into from
Oct 30, 2023

Conversation

alperozturk96
Copy link
Collaborator

Before:
before

After:
after

@tobiasKaminsky This PR includes UI Fix, M3 Conversion and Java to Kotlin.

  • [ Done ] Tests written, or not not needed

@alperozturk96
Fix icon background color
445bf8d 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Rename .java to .kt
d919816 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Use M3 and convert to kt
1b0b5d7 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Fix kotlin spotless check
93ba663 
Signed-off-by: alperozturk <[email protected]>
@github-actions
Copy link

Codacy

Lint

TypemasterPR
Warnings7979
Errors00

SpotBugs

CategoryBaseNew
Bad practice2626
Correctness8484
Dodgy code414412
Experimental22
Internationalization99
Malicious code vulnerability22
Multithreaded correctness99
Performance5858
Security1818
Total622620

@github-actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12098.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@joshtrichards joshtrichards linked an issue Oct 27, 2023 that may be closed by this pull request
Choose storage location: ui bug #11996
Closed
@joshtrichards joshtrichards added hotspot: device storage Storage (on-device) related. Permissions, paths, inconsistencies, etc. bug labels Oct 27, 2023
AndyScherzinger
AndyScherzinger approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndyScherzinger AndyScherzinger merged commit 96ee07f into master Oct 30, 2023
23 checks passed
@delete-merged-branch delete-merged-branch bot deleted the bugfix/choose-storage-location-ui-bug-11996 branch October 30, 2023 11:41
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.27.0 milestone Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees
No one assigned
Labels
3. to review bug hotspot: device storage Storage (on-device) related. Permissions, paths, inconsistencies, etc.
Projects
None yet
Milestone
Nextcloud App 3.27.0
Development

Successfully merging this pull request may close these issues.

Choose storage location: ui bug
3 participants
@alperozturk96 @AndyScherzinger @joshtrichards