Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix Share Is No Longer Available After Renaming Folder #12094

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Bugfix Share Is No Longer Available After Renaming Folder #12094

merged 3 commits into from
Nov 9, 2023

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Oct 25, 2023 •
edited by AndyScherzinger
Loading

  • Tests written, or not not needed

ZetaTom
ZetaTom reviewed Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@ZetaTom ZetaTom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, I wasn't able to reproduce any such issue building from master. Could you please explain the reason behind this change or provide additional information?

@ZetaTom
Copy link
Collaborator

ZetaTom commented Nov 1, 2023

Unfortunately, I wasn't able to reproduce any such issue building from master. Could you please explain the reason behind this change or provide additional information?

The following procedure was used to successfully reproduce the issue on master:

  1. Open Nextcloud Android app
  2. Create new folder
  3. Share folder via email or link
  4. Rename folder
  5. Re-open share menu
  6. Observe that the shared link isn't displayed

@AndyScherzinger AndyScherzinger force-pushed the bugfix/share-is-no-longer-available-after-renaming-folder-9652183 branch 2 times, most recently from fa4b22e to 566c8ef Compare November 2, 2023 09:53
@tobiasKaminsky
Copy link
Member

/rebase

@nextcloud-command nextcloud-command force-pushed the bugfix/share-is-no-longer-available-after-renaming-folder-9652183 branch from 962957f to da965bb Compare November 6, 2023 14:49
@AndyScherzinger AndyScherzinger force-pushed the bugfix/share-is-no-longer-available-after-renaming-folder-9652183 branch from da965bb to d4f1382 Compare November 8, 2023 17:46
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

Codacy

Lint

TypemasterPR
Warnings7775
Errors00

SpotBugs

CategoryBaseNew
Bad practice2626
Correctness7272
Dodgy code367367
Experimental22
Internationalization99
Malicious code vulnerability22
Multithreaded correctness99
Performance5858
Security1818
Total563563

@AndyScherzinger AndyScherzinger force-pushed the bugfix/share-is-no-longer-available-after-renaming-folder-9652183 branch from c533825 to d4737ed Compare November 9, 2023 15:37
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.27.0 milestone Nov 9, 2023
@AndyScherzinger AndyScherzinger merged commit 263e6e0 into master Nov 9, 2023
16 of 18 checks passed
@delete-merged-branch delete-merged-branch bot deleted the bugfix/share-is-no-longer-available-after-renaming-folder-9652183 branch November 9, 2023 15:38
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12094.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@JonasMayerDev
Copy link
Collaborator

I think leads to this issue: #12215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes

@ZetaTom ZetaTom ZetaTom approved these changes

@AndyScherzinger AndyScherzinger Awaiting requested review from AndyScherzinger

@JonasMayerDev JonasMayerDev Awaiting requested review from JonasMayerDev

Assignees
No one assigned
Labels
3. to review bug
Projects
None yet
Milestone
Nextcloud App 3.27.0
Development

Successfully merging this pull request may close these issues.
6 participants
@alperozturk96 @ZetaTom @tobiasKaminsky @JonasMayerDev @AndyScherzinger @joshtrichards