Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Material Design 3 For File Details Sharing Process Fragment #12085

Merged
merged 5 commits into from
Nov 1, 2023
Merged

Use Material Design 3 For File Details Sharing Process Fragment #12085

merged 5 commits into from
Nov 1, 2023

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Oct 24, 2023 •
edited by AndyScherzinger
Loading

Before:
Screenshot 2023-10-24 at 10 25 35

After:
after

  • Tests written, or not not needed

alperozturk96
alperozturk96 commented Oct 24, 2023
View reviewed changes
app/src/main/java/com/nextcloud/utils/extensions/BundleExtensions.kt
import android.os.Bundle
import android.os.Parcelable
import java.io.Serializable

Copy link
Collaborator Author

@alperozturk96 alperozturk96 Oct 24, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These function needed for getting argument and part of this PR also will be used in future for other fragments.

@alperozturk96 alperozturk96 changed the title Feature/use m3 file details sharing process fragment Use Material Design 3 For File Details Sharing Process Fragment Oct 24, 2023
@AndyScherzinger AndyScherzinger force-pushed the feature/use-m3-FileDetailsSharingProcessFragment branch from c486ad9 to c3a9060 Compare October 30, 2023 17:57
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.27.0 milestone Oct 30, 2023
@AndyScherzinger AndyScherzinger force-pushed the feature/use-m3-FileDetailsSharingProcessFragment branch from c3a9060 to f0a9a11 Compare October 30, 2023 18:28
@alperozturk96 @AndyScherzinger
Use M3 Components
d5cc888 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 @AndyScherzinger
Remove deprecated usage
c4e3718 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 @AndyScherzinger
Refactor funcs
85f8017 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 @AndyScherzinger
Fix kotlin spotless check
5f338c2 
Signed-off-by: alperozturk <[email protected]>
@AndyScherzinger AndyScherzinger force-pushed the feature/use-m3-FileDetailsSharingProcessFragment branch from f0a9a11 to 5f338c2 Compare October 30, 2023 18:38
@alperozturk96
Merge master
44d0460 
Signed-off-by: alperozturk <[email protected]>
@github-actions
Copy link

Codacy

Lint

TypemasterPR
Warnings7979
Errors00

SpotBugs

CategoryBaseNew
Bad practice2626
Correctness7878
Dodgy code385385
Experimental22
Internationalization99
Malicious code vulnerability22
Multithreaded correctness99
Performance5656
Security1818
Total585585

@github-actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12085.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@AndyScherzinger AndyScherzinger merged commit ae658f8 into master Nov 1, 2023
18 of 20 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feature/use-m3-FileDetailsSharingProcessFragment branch November 1, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
Nextcloud App 3.27.0
Development

Successfully merging this pull request may close these issues.
2 participants
@alperozturk96 @AndyScherzinger