Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Java to Kotlin Expiration Date Picker Dialog Fragment #12084

Merged
merged 4 commits into from
Oct 31, 2023
Merged

Convert Java to Kotlin Expiration Date Picker Dialog Fragment #12084

merged 4 commits into from
Oct 31, 2023

Conversation

alperozturk96
Copy link
Collaborator

  • [ Done ] Tests written, or not not needed

@AndyScherzinger AndyScherzinger force-pushed the refactor/convert-to-kt-ExpirationDatePickerDialogFragment branch from da9782e to 237019f Compare October 30, 2023 18:28
@alperozturk96 @AndyScherzinger
Rename .java to .kt
10a95e2 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 @AndyScherzinger
Convert to kt
da9646a 
Signed-off-by: alperozturk <[email protected]>
@AndyScherzinger AndyScherzinger force-pushed the refactor/convert-to-kt-ExpirationDatePickerDialogFragment branch from 237019f to da9646a Compare October 30, 2023 18:38
@alperozturk96
Merge master
b9e5c10 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Suppress MagicNumber
6fce720 
Signed-off-by: alperozturk <[email protected]>
@github-actions
Copy link

Codacy

Lint

TypemasterPR
Warnings7979
Errors00

SpotBugs

CategoryBaseNew
Bad practice2626
Correctness7878
Dodgy code385385
Experimental22
Internationalization99
Malicious code vulnerability22
Multithreaded correctness99
Performance5656
Security1818
Total585585

@github-actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12084.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@AndyScherzinger AndyScherzinger merged commit d0129b3 into master Oct 31, 2023
18 of 20 checks passed
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.27.0 milestone Oct 31, 2023
@delete-merged-branch delete-merged-branch bot deleted the refactor/convert-to-kt-ExpirationDatePickerDialogFragment branch October 31, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
Nextcloud App 3.27.0
Development

Successfully merging this pull request may close these issues.
2 participants
@alperozturk96 @AndyScherzinger