Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update themes.xml #12075

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KUSHAL-RAJ-PAREEK
Copy link

change the theme to app theme toolbar to NoActionbar for transparent look.

  • Tests written, or not not needed

change the theme to app theme toolbar to NoActionbar for transparent look.

Signed-off-by: KUSHAL RAJ PAREEK <[email protected]>
@KUSHAL-RAJ-PAREEK
Copy link
Author

change code of toolbar to make it transparent in file app/src/main/res/values/themes.xml.

Copy link
Collaborator

@ZetaTom ZetaTom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KUSHAL-RAJ-PAREEK thank you for your contribution. During my brief tests, I wasn't able to immediately see any discernible differences in the visual appearance. Could you please elaborate on the rationale behind this change?

@KUSHAL-RAJ-PAREEK
Copy link
Author

in some versions toolbar is getting default device colour from this change it will stay transparent in any condition as people demanding in issue for better UI.

Copy link

github-actions bot commented Apr 2, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants