Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Material Design 3 For Loading Popup #12070

Merged
merged 4 commits into from
Oct 30, 2023
Merged

Use Material Design 3 For Loading Popup #12070

merged 4 commits into from
Oct 30, 2023

Conversation

alperozturk96
Copy link
Collaborator

Before:
before

After:
after

  • [ Done ] Tests written, or not not needed

@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.27.0 milestone Oct 30, 2023
@github-actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12070.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link

Codacy

Lint

TypemasterPR
Warnings7979
Errors00

SpotBugs

CategoryBaseNew
Bad practice2626
Correctness7979
Dodgy code401400
Experimental22
Internationalization99
Malicious code vulnerability22
Multithreaded correctness99
Performance5858
Security1818
Total604603

@AndyScherzinger AndyScherzinger merged commit 65440f9 into master Oct 30, 2023
19 of 20 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feature/use-m3-loading-dialog branch October 30, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
Nextcloud App 3.27.0
Development

Successfully merging this pull request may close these issues.
2 participants
@alperozturk96 @AndyScherzinger