Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Material Design 3 For Gallery Bottom Sheet #12067

Merged
merged 6 commits into from
Oct 31, 2023
Merged

Use Material Design 3 For Gallery Bottom Sheet #12067

merged 6 commits into from
Oct 31, 2023

Conversation

alperozturk96
Copy link
Collaborator

Before:
before

After:
after

  • [ Done ] Tests written, or not not needed

alperozturk96 and others added 6 commits October 31, 2023 18:05
@alperozturk96 @AndyScherzinger
Remove IDE warnings
e25421f 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 @AndyScherzinger
Use M3
51d953b 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 @AndyScherzinger
Use Text Button
435fc5a 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 @AndyScherzinger
Increase button tap area
7671f74 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 @AndyScherzinger
Fix kotlin spotless check
302887e 
Signed-off-by: alperozturk <[email protected]>
@AndyScherzinger
change background to surface for bottomsheet
232d1a9 
Signed-off-by: Andy Scherzinger <[email protected]>
@AndyScherzinger AndyScherzinger force-pushed the feature/use-m3-GalleryFragmentBottomSheetDialog branch from d421295 to 232d1a9 Compare October 31, 2023 17:05
@github-actions GitHub Actions
Copy link

Codacy

Lint

TypemasterPR
Warnings7979
Errors00

SpotBugs

CategoryBaseNew
Bad practice2626
Correctness7878
Dodgy code385385
Experimental22
Internationalization99
Malicious code vulnerability22
Multithreaded correctness99
Performance5656
Security1818
Total585585

@github-actions GitHub Actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12067.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions GitHub Actions
Copy link

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.27.0 milestone Oct 31, 2023
@AndyScherzinger AndyScherzinger merged commit 0826400 into master Oct 31, 2023
17 of 19 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feature/use-m3-GalleryFragmentBottomSheetDialog branch October 31, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
Nextcloud App 3.27.0
Development

Successfully merging this pull request may close these issues.
2 participants
@alperozturk96 @AndyScherzinger