Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Material Design 3 For Send Files Bottom Sheet #12064

Merged
merged 6 commits into from
Oct 31, 2023
Merged

Use Material Design 3 For Send Files Bottom Sheet #12064

merged 6 commits into from
Oct 31, 2023

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Oct 18, 2023 •
edited by AndyScherzinger
Loading

  • Tests written, or not not needed

@alperozturk96
Copy link
Collaborator Author

@tobiasKaminsky Failed due to ActivitiesActivityIT - showActivities screenshot test. It's not related to this PR. Every once in a while, other PRs also have problems with this screenshot test. I don't know why, but it would be nice if we could solve it :)

Screenshot 2023-10-26 at 14 41 46

@alperozturk96
Copy link
Collaborator Author

Tests are failing due to same reason

@AndyScherzinger AndyScherzinger force-pushed the feature/use-m3-SendFilesDialog-BottomSheet branch from 3b9d8b6 to 9837538 Compare October 31, 2023 18:49
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.27.0 milestone Oct 31, 2023
@AndyScherzinger AndyScherzinger force-pushed the feature/use-m3-SendFilesDialog-BottomSheet branch from 9837538 to 962c822 Compare October 31, 2023 19:33
alperozturk96 and others added 6 commits October 31, 2023 20:43
@alperozturk96 @AndyScherzinger
Rename .java to .kt
31757f8 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 @AndyScherzinger
Use M3
fc73155 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 @AndyScherzinger
Update UI
45a9b49 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 @AndyScherzinger
Update screenshots
3dddafa 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 @AndyScherzinger
Fix code analytics warnings
35f85f3 
Signed-off-by: alperozturk <[email protected]>
@AndyScherzinger
use surface for background color on bottomsheet
63d967b 
Signed-off-by: Andy Scherzinger <[email protected]>
@AndyScherzinger AndyScherzinger force-pushed the feature/use-m3-SendFilesDialog-BottomSheet branch from 962c822 to 63d967b Compare October 31, 2023 19:43
@github-actions GitHub Actions
Copy link

Codacy

Lint

TypemasterPR
Warnings7878
Errors00

SpotBugs

CategoryBaseNew
Bad practice2626
Correctness7878
Dodgy code377376
Experimental22
Internationalization99
Malicious code vulnerability22
Multithreaded correctness99
Performance5656
Security1818
Total577576

@github-actions GitHub Actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12064.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions GitHub Actions
Copy link

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@AndyScherzinger AndyScherzinger merged commit 9e17bcb into master Oct 31, 2023
17 of 19 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feature/use-m3-SendFilesDialog-BottomSheet branch October 31, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
Nextcloud App 3.27.0
Development

Successfully merging this pull request may close these issues.
2 participants
@alperozturk96 @AndyScherzinger