Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Extra Info from Files Export Notification #12053

Merged
merged 5 commits into from
Oct 20, 2023

Conversation

alperozturk96
Copy link
Collaborator

Before:
before

After:
after

Large icon removed, user info removed. File export triggers file download, so there are multiple notifications.

  • [ Done ] Tests written, or not not needed

@alperozturk96 alperozturk96 changed the title Remove extra info from files export Remove Extra Info from Files Export Notification Oct 17, 2023
@alperozturk96
Copy link
Collaborator Author

/rebase

@nextcloud-command nextcloud-command force-pushed the feature/use-m3-files-export-notification branch from 71706f7 to 1ffbca4 Compare October 19, 2023 10:52
Signed-off-by: alperozturk <[email protected]>
…fication' into feature/use-m3-files-export-notification

# Conflicts:
#	app/src/main/java/com/nextcloud/client/jobs/FilesExportWork.kt
Signed-off-by: alperozturk <[email protected]>
@github-actions
Copy link

Codacy

Lint

TypemasterPR
Warnings8080
Errors00

SpotBugs

CategoryBaseNew
Bad practice2626
Correctness8585
Dodgy code422422
Experimental22
Internationalization99
Malicious code vulnerability22
Multithreaded correctness99
Performance5858
Security1818
Total631631

@github-actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12053.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@alperozturk96 alperozturk96 merged commit c3a5c5c into master Oct 20, 2023
20 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feature/use-m3-files-export-notification branch October 20, 2023 14:26
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.27.0 milestone Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants