Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Material Design 3 File Downloader Notification #12052

Merged
merged 8 commits into from
Oct 30, 2023

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Oct 17, 2023

Guideline:
Guideline

We don't need to add buttons for downloading because it's not cancelable operation.

Before:
Screenshot 2023-10-17 at 12 00 37

before

After:
1

2

Filename too long to show. We can take maybe first 10 character? @AndyScherzinger @tobiasKaminsky

  • [ Done ] Tests written, or not not needed

@alperozturk96
Copy link
Collaborator Author

@nextcloud/designers-community Some file names are too long and hard to show in notifications. What if we do something like this?

e.g file name: image-11.11.2011-tes-scrolls.jpeg

  1. image-11.11.20...jpeg download
  2. Downloading image-11.11.20...jpeg

@tobiasKaminsky
Copy link
Member

As we wait for answer by Designers, I set "2. developing".

@nimishavijay
Copy link
Member

@alperozturk96 nice! We could go with option 2, since file names are (most of the time) not easily understandable anyway :)

@github-actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12052.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link

Codacy

Lint

TypemasterPR
Warnings7979
Errors00

SpotBugs

CategoryBaseNew
Bad practice2626
Correctness8484
Dodgy code414414
Experimental22
Internationalization99
Malicious code vulnerability22
Multithreaded correctness99
Performance5856
Security1818
Total622620

@alperozturk96
Copy link
Collaborator Author

@tobiasKaminsky Failed due to

FileMenuFilterIT - filter_unset_encryption(), filter_select_all(), filter_noLockingCapability_lockItemsInvisible()

these test, on my local machine all tests are passing, fyi.

@AndyScherzinger AndyScherzinger force-pushed the feature/use-m3-file-downloader-notification branch from 0b1018b to 9d1ac6b Compare October 30, 2023 18:35
@AndyScherzinger AndyScherzinger merged commit 3d5ee8a into master Oct 30, 2023
8 of 14 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feature/use-m3-file-downloader-notification branch October 30, 2023 18:35
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.27.0 milestone Oct 30, 2023
@github-actions
Copy link

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions
Copy link

test-Unit test failed, but no output was generated. Maybe a preliminary stage failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants