Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Material Design 3 for StoragePermissionDialogFragment #12050

Merged
merged 4 commits into from
Oct 18, 2023
Merged

Use Material Design 3 for StoragePermissionDialogFragment #12050

merged 4 commits into from
Oct 18, 2023

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Oct 16, 2023 •
edited
Loading

Before:
before

After:
Screenshot 2023-10-17 at 12 12 55

  • [ Done ] Tests written, or not not needed

@alperozturk96
Update screenshots
d74343e 
Signed-off-by: alperozturk <[email protected]>
AndyScherzinger
AndyScherzinger requested changes Oct 17, 2023
View reviewed changes
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alperozturk96
after

Dialog background tinting lost

@alperozturk96
Copy link
Collaborator Author

Updated

@alperozturk96
Update screenshot
ed80935 
Signed-off-by: alperozturk <[email protected]>
@github-actions
Copy link

Codacy

Lint

TypemasterPR
Warnings8080
Errors00

SpotBugs

CategoryBaseNew
Bad practice2626
Correctness8585
Dodgy code434434
Experimental22
Internationalization99
Malicious code vulnerability22
Multithreaded correctness99
Performance5959
Security1818
Total644644

@github-actions
Copy link

blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/12050-Screenshot-blue-Light-11-26

@github-actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12050.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@AndyScherzinger AndyScherzinger merged commit 1b30013 into master Oct 18, 2023
20 of 21 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feature/use-m3-StoragePermissionDialogFragment branch October 18, 2023 10:02
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.27.0 milestone Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
Nextcloud App 3.27.0
Development

Successfully merging this pull request may close these issues.
3 participants
@alperozturk96 @AndyScherzinger @tobiasKaminsky