Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use M3 for SyncedFolderPreferencesDialogFragment #12049

Merged
merged 18 commits into from
Oct 30, 2023
Merged

Use M3 for SyncedFolderPreferencesDialogFragment #12049

merged 18 commits into from
Oct 30, 2023

Conversation

alperozturk96
Copy link
Collaborator

Before:
before_sync

After:
after

  • [ Done ] Tests written, or not not needed

@tobiasKaminsky
Copy link
Member

On first screenshot run size of dialog changed.
Let's check if on second try it is the same.
If so, then we need to update screenshot.

@tobiasKaminsky tobiasKaminsky force-pushed the feature/use-m3-SyncedFolderPreferencesDialogFragment branch from 7e2d1b8 to e2ed8a7 Compare October 19, 2023 07:48
@alperozturk96
Merge master
de4ee9b 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Merge remote-tracking branch 'origin/feature/use-m3-SyncedFolderPrefe…
1ddf3de 
…rencesDialogFragment' into feature/use-m3-SyncedFolderPreferencesDialogFragment
@alperozturk96
Merge master
10e22d6 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Update screenshots
c4e386f 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Merge master
026c7aa 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Rename .java to .kt
b18799a 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Convert to kt
485d68c 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Refactor
1a77dc9 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Suppress magic number
ea099b5 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Merge master
c9421c0 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Revert ss
f016d0b 
Signed-off-by: alperozturk <[email protected]>
@github-actions
Copy link

Codacy

Lint

TypemasterPR
Warnings7979
Errors00

SpotBugs

CategoryBaseNew
Bad practice2626
Correctness8484
Dodgy code414403
Experimental22
Internationalization99
Malicious code vulnerability22
Multithreaded correctness99
Performance5858
Security1818
Total622611

@github-actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12049.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link

blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/12049-Screenshot-blue-Light-14-25

@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.27.0 milestone Oct 30, 2023
@AndyScherzinger AndyScherzinger merged commit 2d6a8c4 into master Oct 30, 2023
18 of 20 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feature/use-m3-SyncedFolderPreferencesDialogFragment branch October 30, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
Nextcloud App 3.27.0
Development

Successfully merging this pull request may close these issues.
3 participants
@alperozturk96 @tobiasKaminsky @AndyScherzinger