Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SSL Validator Dialog #12048

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Remove SSL Validator Dialog #12048

merged 3 commits into from
Oct 18, 2023

Conversation

alperozturk96
Copy link
Collaborator

  • [ Done ] Tests written, or not not needed

@alperozturk96
Remove unused code
34bea23 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 alperozturk96 changed the title Remove SSL Validator Class Remove SSL Validator Dialog Oct 16, 2023
@github-actions
Copy link

Codacy

Lint

TypemasterPR
Warnings8080
Errors00

SpotBugs

CategoryBaseNew
Bad practice2626
Correctness8585
Dodgy code434432
Experimental22
Internationalization99
Malicious code vulnerability22
Multithreaded correctness99
Performance5958
Security1818
Total644641

@github-actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12048.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link

blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/12048-Screenshot-blue-Light-13-59

@tobiasKaminsky tobiasKaminsky merged commit c6795dd into master Oct 18, 2023
20 of 21 checks passed
@delete-merged-branch delete-merged-branch bot deleted the refactor/remove-unused-ssl-validator-dialog branch October 18, 2023 05:18
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.27.0 milestone Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
Nextcloud App 3.27.0
Development

Successfully merging this pull request may close these issues.
3 participants
@alperozturk96 @tobiasKaminsky @AndyScherzinger