Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Material Design 3 share password dialog fragment #12047

Merged
merged 9 commits into from
Oct 30, 2023
Merged

Use Material Design 3 share password dialog fragment #12047

merged 9 commits into from
Oct 30, 2023

Conversation

alperozturk96
Copy link
Collaborator

Before Enforced:
before_enforced

After Enforced:
after_enforced

Before Optional:
before optional

After Optional:
after_optional

  • [ Done ] Tests written, or not not needed

@tobiasKaminsky
Copy link
Member

Please update screenshots related to this PR.

tobiasKaminsky
tobiasKaminsky requested changes Oct 19, 2023
View reviewed changes
Copy link
Member

@tobiasKaminsky tobiasKaminsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update screenshots

@alperozturk96
Merge master
ef31d02 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Update Screenshots
d9561da 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Rename .java to .kt
0a1f567 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Convert to kt
506d1b2 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Merge master
891a63f 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Merge master
b39e7f7 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Fix line length
724c7a5 
Signed-off-by: alperozturk <[email protected]>
@github-actions
Copy link

Codacy

Lint

TypemasterPR
Warnings7979
Errors00

SpotBugs

CategoryBaseNew
Bad practice2626
Correctness8484
Dodgy code414404
Experimental22
Internationalization99
Malicious code vulnerability22
Multithreaded correctness99
Performance5858
Security1818
Total622612

@github-actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12047.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@alperozturk96
Copy link
Collaborator Author

@tobiasKaminsky Failed due to

Screenshot 2023-10-26 at 14 27 47

@AndyScherzinger AndyScherzinger merged commit c52bad8 into master Oct 30, 2023
19 of 20 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feature/use-m3-SharePasswordDialogFragment branch October 30, 2023 18:33
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.27.0 milestone Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
Nextcloud App 3.27.0
Development

Successfully merging this pull request may close these issues.
3 participants
@alperozturk96 @tobiasKaminsky @AndyScherzinger