Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Material Design 3 ChooseTemplateDialogFragment #12044

Merged
merged 2 commits into from
Oct 20, 2023
Merged

Use Material Design 3 ChooseTemplateDialogFragment #12044

merged 2 commits into from
Oct 20, 2023

Conversation

alperozturk96
Copy link
Collaborator

  • [ Done ] Tests written, or not not needed

@alperozturk96
Copy link
Collaborator Author

/rebase

@nextcloud-command nextcloud-command force-pushed the feature/use-m3-ChooseTemplateDialogFragment branch from 2546005 to 00379a3 Compare October 16, 2023 14:49
@tobiasKaminsky tobiasKaminsky force-pushed the feature/use-m3-ChooseTemplateDialogFragment branch from 00379a3 to df85896 Compare October 19, 2023 07:47
alperozturk96 and others added 2 commits October 20, 2023 17:14
@alperozturk96 @AndyScherzinger
Use M3 ChooseTemplateDialogFragment
c517781 
Signed-off-by: alperozturk <[email protected]>
@tobiasKaminsky @AndyScherzinger
apply spotless
7f308fd 
Signed-off-by: tobiasKaminsky <[email protected]>
@AndyScherzinger AndyScherzinger force-pushed the feature/use-m3-ChooseTemplateDialogFragment branch from a19adb4 to 7f308fd Compare October 20, 2023 15:14
@github-actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12044.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link

Codacy

Lint

TypemasterPR
Warnings8080
Errors00

SpotBugs

CategoryBaseNew
Bad practice2626
Correctness8585
Dodgy code422422
Experimental22
Internationalization99
Malicious code vulnerability22
Multithreaded correctness99
Performance5858
Security1818
Total631631

@AndyScherzinger AndyScherzinger merged commit 0689f26 into master Oct 20, 2023
20 checks passed
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.27.0 milestone Oct 20, 2023
@delete-merged-branch delete-merged-branch bot deleted the feature/use-m3-ChooseTemplateDialogFragment branch October 20, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
Nextcloud App 3.27.0
Development

Successfully merging this pull request may close these issues.
3 participants
@alperozturk96 @AndyScherzinger @tobiasKaminsky