Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Material Design 3 For Confirmation Dialog #12041

Merged
merged 24 commits into from
Oct 30, 2023
Merged

Use Material Design 3 For Confirmation Dialog #12041

merged 24 commits into from
Oct 30, 2023

Conversation

alperozturk96
Copy link
Collaborator

  • [ Done ] Tests written, or not not needed

@tobiasKaminsky
Copy link
Member

👏 👏 for testing RTL

@tobiasKaminsky tobiasKaminsky force-pushed the feature/use-m3-confirmation-dialog branch from 228c215 to e80568b Compare October 18, 2023 05:10
@tobiasKaminsky
Copy link
Member

Hm.

java.io.FileNotFoundException: Source '/Users/runner/work/android/android/app/screenshots/gplay/debug/com.owncloud.android.ui.dialog.DialogFragmentIT_testConfirmationDialogWithThreeActionRTL.png' does not exist

Seems that test will not create an output if a screenshot is missing.
Maybe this has changed.
So I think you need to run it locally and add the expected screenshot.

tobiasKaminsky
tobiasKaminsky requested changes Oct 19, 2023
View reviewed changes
Copy link
Member

@tobiasKaminsky tobiasKaminsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add missing screenshot
rebase

@alperozturk96
Merge master
e6dc896 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Merge remote-tracking branch 'origin/feature/use-m3-confirmation-dial…
1f84649 
…og' into feature/use-m3-confirmation-dialog
@alperozturk96
Clean import
f125b29 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Rename .java to .kt
7ad5fc7 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Convert to kt
ea49810 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Merge master
6dab18b 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Merge master
96f1f42 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Remove spread operator
fc53132 
Signed-off-by: alperozturk <[email protected]>
@github-actions
Copy link

Codacy

Lint

TypemasterPR
Warnings7979
Errors00

SpotBugs

CategoryBaseNew
Bad practice2626
Correctness8484
Dodgy code414414
Experimental22
Internationalization99
Malicious code vulnerability22
Multithreaded correctness99
Performance5858
Security1818
Total622622

@github-actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12041.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link

blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/12041-Screenshot-blue-Light-15-54

@AndyScherzinger AndyScherzinger merged commit d13f280 into master Oct 30, 2023
18 of 20 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feature/use-m3-confirmation-dialog branch October 30, 2023 18:32
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.27.0 milestone Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
Nextcloud App 3.27.0
Development

Successfully merging this pull request may close these issues.
3 participants
@alperozturk96 @tobiasKaminsky @AndyScherzinger